OFBiz Development SVN r 6108

38 new commits this week. SVN 6108 builds and installs successfully.

Significant changes this week

1. The long-awaited re-factoring of the sales tax data model and functions have started with new screens and services in the accounting application.
2. There is a new capability to generate a PDF of a quote and send it to someone as an attachment.
   

Thanks to our contributors
This week's contributors include Hans Bakker, Ray Barlow, Jacopo, David, Andy, Leon Torres, and myself.

Accounting

• New GlAccountTypes for "Uninvoiced Shipment Receipts" and "Purchase Price Variance" and demo GL accounts for these. The idea is that we want to be able to account for inventory receipts as soon as they are received and then later reconcile purchase invoices against the original PO through the variance account. (r 6071)
• OrderRole values are now propagated to InvoiceRole values. (r 6075)
• Implemented TaxAuthority data maintenance user interfaces and services in the accounting application. (r 6081)
• Improvement to InvoiceWorker.getInvoiceAddressByType - if an address is not found from InvoiceContactMech, it will now go look for it from PartyContactMechPurpose, using partyId based on type of invoice. If it still doesn't find an address of the specified type, it'll get you the GENERAL_LOCATION. (r 6099)

Accounting/General Ledger

• Changed posting of inventory and accounts payable invoices: Inventory values are posted to GL as soon as they are received against Uninvoiced Shipment Receipts based on original purchase order prices. Accounts Payable invoices are matched against Uninvoiced Shipment Receipts, and the difference between PO and invoice price is reconciled in a Purchase Price Variance account.
• Better invoice PDFs
  
• Some UI changes to the invoice forms
  

Base and Framework

• New condition-object" definition in form widget (similar to condition-expr and condition-list) (r 6080)
• Fixed problem with get-related not working when the source doesn't exist in screen widget. (r 6080, 6082)
• Fixed missing login messages. (r 6084)
• createNote service will now accept a "noteDate" parameter if it is passed in and use the current time if it is not. (r 6102)

Entity Model

• New relationship from FixedAssetStdCost to FixedAsset (r 6076)
• OrderHeader has new fields "externalId" and "internalCode" for help with integration. (r 6088)
• New view entity CountryTeleCodeAndName which helps lookup phone codes for countries. (r 6091)
• Fixed method in ModelEntity.convertFieldValue to not break GenericEntity.NULL_FIELD and convert it to a String when the field's Java type is String. (r 6095, 6096)

Marketing

• Clean up of marketing application code and fixed the SegmentGroup lookup form. (r 6074)

Order

• Converted field-to-field, env-to-field, and string-to-field to "set" in CustRequestServices and QuoteServices minilang script. (r 6077, 6078)
• OrderHeader has new fields "externalId" and "internalCode" for help with integration. (r 6088)
• New Quote PDF and new ability to send a quote confirmation email (with PDF attached) from the View Quote screen of order manager. (r 6083, 6089, 6097)
• Patch to fix NPE in order PDF's company header section (r 6092)
• New and improved company header for order receipts and other PDFs: it will now retrieve company information and logo from the database settings. (r 6100, 6101)
• ShoppingCartItem now sets base price internally using setBasePrice method instead of "=" assignment. Cleans up code. (r 6104)
• storeOrder service now suppoprts setting externalId and internalCode parameters and Lists of orderAttributes and orderItemAttributes. (r 6105)
• Quote attributes will now be stored as order attributes. (r 6106)
• When creating quotes, will now copy productStoreId from custRequest to quote. Also, will no longer create quote role of REQ_TAKER, since that is automatically done. (r 6107)
• Fixed bug where shopping cart was looking for "description" instead of "comments" from QuoteItem. (r 6108)

Party

• Edit shopping list form in party manager now has a field for modifying the quantity purchased. (r 6072)
• Cleanup of party screens and forms, especially the SegmentGroup screens. editcontactmech.bsh now only looks for partyId (instead of party_id as well). Changing from request.getParameter to parameters.get (r 6073, 6094)
• createPerson now passing in full context parameters to createNote (r 6103)

Product

• Adds check that orderItemShipGrpInvRes.quantity is not null when creating an item issuance (in IssuanceServices.xml#createItemIssuance) (r 6086)
• Fixed bad field name for unitCost on form in facility manager to update inventory items (r 6087)

Seed Data

• New GlAccountTypes for "Uninvoiced Shipment Receipts" and "Purchase Price Variance" and demo GL accounts for these. The idea is that we want to be able to account for inventory receipts as soon as they are received and then later reconcile purchase invoices against the original PO through the variance account. (r 6071)

Work Effort

• Corrected name of "addWorkEffortTimeToInvoice" (r 6085)

eCommerce

• Added Roles information to the Request and Quote reports in ecommerce. (r 6079)