OFBiz Development r489516

41 new commits this week. SVN r 489516 builds and installs successfully. Significant changes:

1. Re-factoring and improvements to the way billing accounts are handled during checkout and order creation
2. General improvements and bug fixes
3. opentaps Financials now supports sales commission invoices, payments, statements, and balances
   

Accounting

• combine ListFixedAssetStdCosts and EditFixedAssetStdCost defined in FixedAssetScreens.xml into one screen (r 488562)
• Added default system currency for fixed asset std costs. (r 488565)
• additional billing account available balance method (r 488867)
• refactored billing account worker to produce a getBillingAccountOpenOrders method (r 488878)
• More chinese translations (r 489139)
• Fix bad link from invoice overview to product (r 489144)
• Fixed invoice dropdown to use the invoiceTypeId and InvoiceItemTypeMap to select the available invoiceItemTypes (r 489188, 489229, 489239)

Base and Framework

• Fixed hardcoded string to POS startup file in GUIAPP component (r 487891)
• Fix bug where JavaMailContainer is broken for all password not consisting of only lowercase characters (r 488137)
• Removed log4j.appender.css.DatePattern='.'yyyy-MM-dd-HH-mm'.html' from debug.properties (r 488284)
• Added valve to support incoming HTTP requests from an SSL Accelerator that are not HTTPS/SSL requests, but that should be treated by the server as secure (r 488748)

Entity Model

• Add a description field to the subscription entity to be able to have a textfield search on this entity. (r 489236)

Order

• When a cart is loaded from an existing order, if the ship group is associated to a supplier, then this information is stored in the cart. (r 487780)
• Added link and event to initialize a cart from an existing order: this implements the ability to clone an order. The link to run it is at the bottom of the "order view" screen. (r 487781)
• Fixes for the billing account usage during checkout process (r 488588)
• Clear out rejected payment methods from cart when an order is rejected so they don't get re-authorized. (r 488848)
• Some minor refactorings to the way the billing account is set in the cart: now it is sufficient to set the billing account id using the setBillingAccount* methods (already available) and it is no more necessary to set the payment method to EXT_BILLACT in the cart. In fact the correct OrderPaymentPreference for the billing account is created by the cart when the order is created (if a billingAccountId is set). So now, if you want to add a billing account to the cart you can simply do this: cart.setBillingAccount(billingAccountId, maxAmount); and you can remove the billing account from the cart with: cart.setBillingAccount(null, 0.0); (r 489337)
• Cleaned up variable to avoid incorrect information in the order detail payment box when billing account and other methods are both selected. (r 489405)
• Fixed error messages with accepting returns (r 489476)

Point Of Sales

• Product selection is no longer shown when the SKU brings up only one product (r 487991)
• Fix strange POS behavior (r 488273, 488277, 488471)
• First uses of new posScreen methods setWaitCursor and setNormalCursor : during login and processing sale. (r 488821)

Product

• Fix bug with facility manager menus (r 487666, 487954)
• Set width/height of batch generated shipping labels to 669x724 pixels (r 487794)
• Add a description field to the subscription entity to be able to have a textfield search on this entity. (r 489236)
• fixed incorrect entity name used in remove store promo service (r 489516)

Seed Data

• new return reason: COD payment rejected (r 489205)
• new commission expense gl account type (r 489219)
• better classification of some customer credit, deposit, and prepaid expenses accounts (r 489499)

Web Tools

• Trivial layout and formatting improvement to entity sql processor (r 487969, 487970)

Work Effort

• Fixed update problem when there is no statusId on an existing WorkEffort (r 488040)
• implement WorkEffort keyword indexing and a manual keyword admin screen (r 488043)

eCommerce

• Added demo content for the following (mandatory) InventoryItem fields: currencyUomId, ownerPartyId, unitCost. (r 487971)

opentaps Financials

• Ledger posting for finance charges
• Ledger posting for sales commissions
• Sales commissions reports, including balances by sales rep and statements for individual sales reps
• Sales commission payout supported
• AR/AP reports now include customer deposits, customer credits, and vendor prepaid expenses
• Customer billing account screens now support receiving payments for and paying invoices with billing accounts

opentaps CRM

• When activities (events or tasks) are finished, they are now automatically added time sheets for all the CRM users, allowing for invoicing through the work effort application's time sheet feature.
  

OFBiz Development r487657

60 new commits this week. SVN r 487657 builds and installs successfully. Significant changes this week:

1. JPublish and EdenLib jars are now removed so that newer bsf jars can be added. If you have legacy webapps from OFBIZ 3.x this will break them.
2. Added JSON and ezmorph libraries
3. Fixed bugs with billing account balance calculations
4. Added new WorkEffortContent and Wrappers
5. Refactored OrderItemAssociation entity to give better relationship between order items and their associations.
   

Accounting

• Removed old assignment that was causing some minor issues with login redirection to the main page. (r 484941)
• Fixed bug where payment applications associated to a billing account and to a return invoice were considered in the billing account balance as outbound payment. (r 486051, 486444)
• If a Invoice is applied to a BillingAccount, Payment should be applied to Invoice and also set BillingAccountId in PaymentApplication record. So that the total Invoice amount and Payment amount whould balance for a BillingAccount number. (r 486056)
• additional relations from the PaymentAndApplication view-entity to the Payment and PaymentApplication entities (r 486267, 486443)
• Removed a duplicate create new invoice button from invoice screen (r 486834)
• New GL accounts and account types for supporting sales commissions on the general ledger (r 487381, 487384)

Base and Framework

• Re-factored list of credit card expiration years. (r 484937)
• update path to ofbizssl.jks in jetty-containers.xml. (r 484962)
• Fix bug in lookup party and userlogin screen (r 484979)
• Refactored KeywordSearch class to move some more generic search code and properties to the common component (r 485561)
• Jpublish and EdenLib removed (r 485565)
• Fix some css typos (r 4858974)
• Add JSON-0.9 library (r 485984)
• Add ezmorph-0.9.1 (r 485984)
• added event handler to wrap around the service event handler and return the output as a JSONObject (for use w/ AJAX) (r 485986)
• Upgraded bsf to bsf-2.4.0 and upgraded related BSF engine and handlers (r 486518)
• Removed jpublish from the OFBIZ SVN (r 486969)
• Removed unnecessary extra cells in list forms (r 486834)
• A new "debug SMTP option" in general.properties to allow easier debugging of SMTP emails. Set mail.debug.on=Y or N in framework/common/config/general.properties (r 487570)
• Fixed some recently introduced form widget bugs: date fields were truncated by a digit, and a previous commit to remove unneeded columns broke the multi-submit form with button (r 487653, 487657)

Content

• Fixed content permission errors (r 484960)
• Commenting out the remove layout feature in LayoutForms (r 484980)
• admin screens, service, etc for the WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard entities (r 486033, 486370)
• Some cleanups on the DataResource text edit pages, and fixed the Html one to actually populate the ElectronicText.textData instead of always leaving it blank (r 487467)

Entity Model

• refactored the entities and code to associate order items: * OrderItemAssociation has been deprecated and renamed to OldOrderItemAssociation * two new entities has been added: OrderItemAssoc and OrderItemAssocType * all the code that was using the OrderItemAssociation entity has been modified to use the new entity * added seed data for the OrderItemAssocType Now the new entity can be used not only to store an association between a sales order item and a purchase order item, but also different kinds of relations, such as drop shipments, replacements, new versions of orders etc... (r 485144)
• Added WorkEffortKeyword entity, which is like the ProductKeyword entity and intended to be used the same way; also added indexes on the keyword fields which can hopefully be used sometimes to speed up queries on this, though not always because of like and wildcards (r 487378)
• Added indexes on the keyword fields which can hopefully be used sometimes to speed up queries on this, though not always because of like and wildcards (r 487378)

Handheld

• Change to not show the "Hand Held Facility" application in the top application bar. (r 484940)

Manufacturing

• Slightly improved navigation and usability of Calendar management screens in the manufacturing application. (r 484952)
• Disabled the ability to edit fixed asset assigned to a production run after the production run has been approved. (r 484955)

Multiple Components

• More code cleanup (r 484971, 484972, 484973, 484974, 484976)
• Jpublish and EdenLib removed (r 485565)

Order

• Fixed bug where adding additional items in order entry messes up values for quantity/remaining/outstanding on cancelled line items (r 484961)
• re-factoring to improve the autoCancelOrderItems service (r 485087)
• refactored the entities and code to associate order items: * OrderItemAssociation has been deprecated and renamed to OldOrderItemAssociation * two new entities has been added: OrderItemAssoc and OrderItemAssocType * all the code that was using the OrderItemAssociation entity has been modified to use the new entity * added seed data for the OrderItemAssocType Now the new entity can be used not only to store an association between a sales order item and a purchase order item, but also different kinds of relations, such as drop shipments, replacements, new versions of orders etc... (r 485144)
• Implemented service to upgrade data from OldOrderItemAssociation to OrderItemAssoc entity. (r 485145)
• The id of order items for replacements orders are now padded to 5 digits (as already happens for standard orders). (r 485697)
• Order items that are replacements of existing order items are now associated using the OrderItemAssoc entity. (r 485718)
• Improved support for new OrderItemAssoc entity: now drop shipped items are associated to their purchase order items by an entry in the OrderItemAssoc entity of type "DROP_SHIPMENT". (r 485750)
• HTML fix in bill settings page (r 486422)
• Fixed bug where orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown (r 487654)

Party

• createPartyPostalAddress now sets contactMechTypeId (r 484977)

Point Of Sales

• Fixed duplicate fk-name to avoid warning messages (r 485664)

Product

• Refactored KeywordSearch class to move some more generic search code and properties to the common component (r 485561)
• Fix possible NPE in Product and Category Content Wrappers and changed them to implement the new ContentWrapper interface (r 485874)
• Added indexes on the keyword fields which can hopefully be used sometimes to speed up queries on this, though not always because of like and wildcards (r 487378)
• Parameterize CommonFacilityDecorator location in FaclityScreens (r 487648)

Work Effort

• New WorkEffortContentWrapper similar to product content wrapper (r 485876, 485966)
• admin screens, service, etc for the WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard entities (r 486033, 486370)
• create work effort quote request now goes to list work effort quotes after completion (r 486864)
• Added WorkEffortKeyword entity, which is like the ProductKeyword entity and intended to be used the same way; also added indexes on the keyword fields which can hopefully be used sometimes to speed up queries on this, though not always because of like and wildcards (r 487378)
• Implemented initial WorkEffortSearch class with a few different constraints, etc; also add some entities for storing data about work effort searches and their results (r 487512)

opentaps CRM

• Mail sorting for USPS business (standard) class mailings

opentaps Financials

• Find billing accounts by customer and view transactions of billing accounts
• Initial version of assessing finance charge (interest) on outstanding invoices
• Improvements to the transaction view screens
  

OFBiz Development r484678

57 new commits this week. SVN r 484678 builds and installs successfully. Significant changes this week include:

1. New handheld component for warehouse handheld operations in the specialpurpose/ component.
2. Upgraded Apache FOP to 0.92 and XUI to 2.0.6
3. Code cleanups to remove unnecessary casts and unused variables.
   

Accounting

• remove some unnecessary casts where the source-type and the casted-to type are identical. (r 481546, 481547, 482260)
• additional fields for acctgtransandentries view entity for linking to invoice and payments (r 483199)
• trivial change to set adjustment amount to BigDecimal ZERO in InvoiceServices (r 483734)

Base and Framework

• Upgraded Freemarker jar from 2.3.4 to 2.3.8 (r 481530)
• remove some unnecessary casts where the source-type and the casted-to type are identical. (r 481546, 481547, 482260)
• Major refactoring of the Apache FOP rendering engine: upgrade from .20.5 to .92 (r 481558)
• Removed unused imports. (r 481561)
• Fix some string comoparison problems (r 482264)
• Allow user to give a name to the job he is scheduling (r 482807)
• New translation of lookup conditions into German (r 482923)
• List of credit card years is now automatic in the ccyears.ftl file (r 483403)

Content

• remove some unnecessary casts where the source-type and the casted-to type are identical. (r 481546, 481547, 482260)
• Removed unused imports. (r 481561)
• Fix bad link on layout forms to remove layout (r 482647)

Handheld

• First commit of the "hhfacility" component a special purpose application for warehouse operations done using hand held devices. The application is still in a very initial stage, a lot of cleanups still need to be done, but it is a nice start. It has been contributed by Daniel Goodwin and Ray Barlow; see OFBIZ-226 for details. Daniel, Ray many thanks to both of you. (r 482800, 482801, 483261)

Manufacturing

• default BOM simulation to manufacturing BOMs, which is what is used for actual productino (r 482752)

Multiple Components

• Removed unused variables from java files (r 483235, 483405)

Order

• Removed unused imports. (r 481561)
• Fix some string comoparison problems (r 482264)
• When an order for a return replacement is automatically created by the system, the order roles are also cloned. (r 482584)
• Now the order created for a return of type "replacement" also has correct information about order ship groups. (r 482615)
• Misc improvements to the XSL-FO tag usage in orderReportContactMechs.fo.ftl (r 482665)
• put in a default currency for the create quote form based on user configured default (r 482753)
• createCustRequest will now check that userLogin actually has a partyId, in case it is called by system user. It may still be nice to assign a party to the system user, but null checking is never bad in my opinion, so I'm going to put this in as well (r 482820)
• Fix a bug where during ordermgr order entry the prices calculated were for the CSR user party instead of for the actual customer (r 483239)
• UI label and translation fixes in English and Dutch. (r 483912)
• add missing externalLoginKey link from order to accounting for viewing billing account (r 484678)

Party

• remove some unnecessary casts where the source-type and the casted-to type are identical. (r 481546, 481547, 482260)
• Removed unused imports. (r 481561)
• better PartyContactMechServices.xml messages and French translations (r 481569, 481728)
• Fixed missing decorator location in two of the communication event screens. (r 482333)
• fixed bug where a ui label for PartyCreateNewCustRequest is duplicated incorrectly (r 482852)
• You can now delete a communicationevent when there are roles attached--the roles are deleted first. (r 483321)
• Added link from view profile to requests, plus changed all sorts of links to order and accounting to use externalLoginKey (r 483715)

Point Of Sales

• remove some unnecessary casts where the source-type and the casted-to type are identical. (r 481546, 481547, 482260)
• Removed unused imports. (r 481561)
• Fix some string comoparison problems (r 482264)
• New sizes of journal fields (customer display screen) to show complete date and total (r 482582)
• Replace previous version of Paid In/Out. This version uses a dialog box with an editable ComboBox for reason. Some miscelaneous refactoring. (r 482591, 482594)
• Upgraded XUI library because the new editing ComboBox in POS needs XUI 2.0.6 (r 482703)

Product

• remove some unnecessary casts where the source-type and the casted-to type are identical. (r 481546, 481547, 482260)
• Cleaned up and simplified the "receiveProductInventory" service (there was still some old code used when the service was implemented as a service group): now it will work well also with serialized items. (r 482685)
• Addition of Two lookups in creation of inventory item (r 483241)
• Initial implementation in the facility manager to get the items with null location. (r 483243)
• filter the list of facilities shown in the main hhfacility screen to the ones of type WAREHOUSE. (r 483909)
• parametrize the path to the common facility decorator screen (r 483918)

Seed Data

• seed and demo data to help with assessing interest charges on invoices (r 481473, 481479, 481480)

Web Tools

• Misc improvements to the Webtools log view screen: - added a new log file appender that decorates the log messages with css; the content of this file is shown by the Webtools screen - log messages containing ${...} notations are now supported (r 481544)
• Allow user to give a name to the job he is scheduling (r 482807)
• A few cleanups to resolve some errors found on EntityRefList page (r 483295)

Work Effort

• Added WorkEffortReview entity, seed data, etc; and a WorkEffortGoodStandardType for associating general sales products to the WorkEffort (r 483332, 483333)

eCommerce

• Fixed Bug in "Update Url/Web Address" (r 481566)
• Couple of places where the Product.productName was used directly instead of the ProductContentWrapper (r 483266)

opentaps CRM

• New catalog request with survey features allows a lead to be created with a catalog request and a survey completed
• Ability to put all domestic and all foreign catalog requests into postal address contact list.
• Ajax auto-complete for creating opportunities can now search on name or partyId
  

opentaps Financials

• Cleaned up customer/vendor statements
  
• Customer/vendor statements can now be printed as a PDF
• New screens and service to set up customer billing accounts.
  

OFBiz Development r480169

52 new commits this week. Significant changes include:

1. Complete re-factoring of the anonymous checkout routine.
2. Fixed the "Service invocation error: commit transaction failed" error messages to show what the actual cause of the error was.
3. Fixed the services for adding and charging balances to the billing account
   

Accounting

• Added missing end tags to escape xml chars in ftl.fo templates: (r 479323, 479529)
• French translation correction (r 479625, 479644)
• fix the service to remove invoice roles (r 479982)
• Fix billing account form's bad label for billing account id. (r 480068)
• Fix problems where FOP 0.92 is more strict about the interpretation of the XSL-FO 1.0 specification (r 480724)
• Fix potential divide by zero bug in create commission invoice services. (r 480727)
• Fixed bugs with billing account so that you can use payment and applications to add value to and apply value from a billing account (r 480796, 481069)
• refactored a new method for BillingAccountWorker.getAccountLimit which can deal with cases when billing account's account limit is null by just returning a ZERO (r 480798)

Base and Framework

• The special characters for xml (not allowed in xsl-fo template) from the data formatted by the form widget are now escaped automatically. (r 478959)
• Now the font size of header, footer and body of simple fo.ftl template can be set in the screen definition. For example, in the action tag of a screen definition: The default is 8pt for all. (r 479624)
• French translation correction (r 479625, 479644)
• Two of the getDescription(...) methods in the ModelFormField class, were returning the string " " if no description was found but will now return an empty "" string. (r 479931)
• French translations for webapp ui labels (r 480492)
• Fix problems where FOP 0.92 is more strict about the interpretation of the XSL-FO 1.0 specification (r 480724)
• Some improvements on error handling and message passing especially for failed commits when rollbackOnly is set. This seems to happen when a rollback is caused by a SECA triggered service failing and was causing the incomprehensible "Service invocation error: commit transaction failed" messages. (r 480741)
• Translation changes (r 481363)

Content

• More JPublish pages converted to screen widget, and more unused files removed. (r 479008, 479016, 479020, 479140, 479154)
• Added missing end tags to escape xml chars in ftl.fo templates: (r 479323, 479529)

Entity Model

• Added WorkEffortContent and WorkEffortContentType entities, part of various upcoming WorkEffort enhancements for a project management type site (r 479957)

Manufacturing

• Added missing end tags to escape xml chars in ftl.fo templates: (r 479323, 479529)
• Fix problems where FOP 0.92 is more strict about the interpretation of the XSL-FO 1.0 specification (r 480724)

Order

• Added missing end tags to escape xml chars in ftl.fo templates: (r 479323, 479529)
• Fix an error in the calculation of the offline payments received for an order: the new amount received is summed two times to the total of already received offline amounts. For example, if the order total is $80, and you receive an offline payment of $50, due to the bad calculation, the method says 50+50 = 100 > 80 and so approves the order. (r 479750)
• always set a currency for the cart when the cart is loaded from a shopping list, even if the currency in the shopping list is null (the one set in the product store, or the one in the general.properties are used). (r 479978)
• Fix problems where FOP 0.92 is more strict about the interpretation of the XSL-FO 1.0 specification (r 480724)

Party

• reverting feature which removed workeffort when sole communicationevent is removed and instead creating a new service deleteCommunicationeventWorkEffort (r 479348, 479350)
• fix bug where credit card billing address doesn't have some fields in the edit credit card page (r 479759)
• use the mainDecorator location in communication event screens (r 479937)
• i18n for PartyContactMechServices.xml (r 480124, 480133)

Product

• ability to duplicate shipment route segments (r 478992, 479001)
• add a subscriptionattributes add screen' (r 479537)
• Fix problems where FOP 0.92 is more strict about the interpretation of the XSL-FO 1.0 specification (r 480724)
• fix bug where null postal code can crash order packing screen. (r 480766)

Seed Data

• Cleaned up two of the Content Manager's seed data. (r 479138)
• added FRIEND PartyRelationshipType (r 480820)

Web Tools

• Fix webtools page size error (r 479578)
• Entity maintenance pages moved from FTL to BSH (r 481364, 481367, 481369)

eCommerce

• Major re-factoring and improvements to the anonymous checkout routine (r 479879, 480761, 480806, 481178)
• Improved ecommerce controller so that before the checkoutpayment page the tax & shipping is calculated, so people can know the right total when splitting payments (r 480151)